Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add ranking functions + make the supported table more obvious #61767

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

mneedham
Copy link
Contributor

@mneedham mneedham commented Mar 22, 2024

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Adding examples for row_number, rank, dense_rank
  • Adding examples for avg/max aggregation functions
  • Making the supported table a bit clearer at a glance
  • Formatting the other queries so they're a bit easier to read

@robot-clickhouse
Copy link
Member

robot-clickhouse commented Mar 22, 2024

This is an automated comment for commit 8f40db2 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

Copy link

clickhouse-ci bot commented Mar 22, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Mar 22, 2024
@nikitamikhaylov
Copy link
Member

@mneedham Please don't ignore the PR template https://github.com/ClickHouse/ClickHouse/blob/master/.github/PULL_REQUEST_TEMPLATE.md otherwise tests won't be launched.

@justindeguzman justindeguzman changed the title add ranking functions + make the supported table more obvious [Docs] add ranking functions + make the supported table more obvious Mar 24, 2024
@justindeguzman justindeguzman added the pr-documentation Documentation PRs for the specific code PR label Mar 24, 2024
@nikitamikhaylov nikitamikhaylov self-assigned this Apr 2, 2024
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Apr 8, 2024
Merged via the queue into ClickHouse:master with commit 5b2f8b2 Apr 8, 2024
60 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants