Throw exceptions if WITH TOTALS/ROLLUP/CUBE are specified without agg… #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've missed two tests using WITH TOTALS without aggregation: 00937_template_output_format and 00378_json_quote_64bit_integers. |
CurtizJ
reviewed
Sep 20, 2019
CurtizJ
reviewed
Sep 20, 2019
|
|
||
| # Must throw an exception | ||
| EXCEPTION_TEXT="WITH TOTALS, ROLLUP or CUBE are not supported without aggregation" | ||
| $CLICKHOUSE_CLIENT --query="SELECT 1 AS id, 'hello' AS s WITH TOTALS" 2>&1 \ |
There was a problem hiding this comment.
It's more convenient to write simple sql test and add special comment after query
-- { serverError 49 }, which means that client would expect exception with code 49.
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
Throw exceptions if WITH TOTALS/ROLLUP/CUBE are specified without agg… (cherry picked from commit 3f500aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…regate functions
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
WITH TOTALS make sense only when you apply aggregation.
...
Detailed description (optional):
...