Fix DUMP debug. #7500
Merged
Fix DUMP debug. #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzm
reviewed
Oct 28, 2019
| @@ -135,7 +129,7 @@ std::ostream & operator<<(std::ostream & stream, const SyntaxAnalyzerResult & wh | |||
| if (!what.aliases.empty()) | |||
| { | |||
| stream << "aliases="; | |||
| dumpValue(stream, what.aliases); | |||
| // dumpValue(stream, what.aliases); | |||
There was a problem hiding this comment.
Should we print something here?
There was a problem hiding this comment.
Oops, that's a mistake.
alexey-milovidov
approved these changes
Oct 29, 2019
|
@akuzm Could you please create an issue (or do a quick fix) for those that were found with fuzz test with UBSan? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
#7419 is wrong. Dependent type cannot be used for template deduction. Also move DUMP AST to parser DSO.