utilize libunwind to achieve better abi-compat #7956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,9 @@ endif () | |||
| set(LIBUNWIND_C_SOURCES | |||
| ${LIBUNWIND_SOURCE_DIR}/src/UnwindLevel1.c | |||
| ${LIBUNWIND_SOURCE_DIR}/src/UnwindLevel1-gcc-ext.c | |||
| ${LIBUNWIND_SOURCE_DIR}/src/Unwind-sjlj.c) | |||
| ${LIBUNWIND_SOURCE_DIR}/src/Unwind-sjlj.c | |||
There was a problem hiding this comment.
(not related to your commit)
Do we really need to compile a translation unit with SJLJ (setjmp, longjmp) impementation of exception handling? (It is not used on all modern architectures).
There was a problem hiding this comment.
quick check shows
#if (defined(__APPLE__) && defined(__arm__)) || defined(__USING_SJLJ_EXCEPTIONS__)
#define _LIBUNWIND_BUILD_SJLJ_APIS
#endif
alexey-milovidov
approved these changes
Nov 28, 2019
nikitamikhaylov
added
the
pr-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
thirdparty libraries such as libhdfs calls libgcc
backtracedirectly, which might lead to ABI mismatch issue when libunwind is enabled and running on old systems