-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added information about paths to system.merges
.
#8043
Added information about paths to system.merges
.
#8043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Ok.
There are no tests, but how we can test it?
Maybe initiate a long (almost infinite) merge of a table that contains function sleep
in ORDER BY, then select from system.merges, then cancel merges.
It's not Ok |
Now it's Ok |
t = threading.Thread(target=optimize) | ||
t.start() | ||
|
||
time.sleep(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make the test flacky.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Added information about paths to
system.merges
.