Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about paths to system.merges. #8043

Merged
merged 13 commits into from
Dec 8, 2019
Merged

Added information about paths to system.merges. #8043

merged 13 commits into from
Dec 8, 2019

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Dec 5, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):

Added information about paths to system.merges.

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok.

There are no tests, but how we can test it?
Maybe initiate a long (almost infinite) merge of a table that contains function sleep in ORDER BY, then select from system.merges, then cancel merges.

@excitoon
Copy link
Contributor Author

excitoon commented Dec 7, 2019

It's not Ok

@excitoon
Copy link
Contributor Author

excitoon commented Dec 7, 2019

Now it's Ok

t = threading.Thread(target=optimize)
t.start()

time.sleep(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make the test flacky.

@alexey-milovidov alexey-milovidov merged commit 16754bf into ClickHouse:master Dec 8, 2019
@KochetovNicolai KochetovNicolai added the pr-feature Pull request with new product feature label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants