Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal specializations for min/max #8144

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

4ertus2
Copy link
Contributor

@4ertus2 4ertus2 commented Dec 11, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Performance Improvement

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Faster mix/max aggregtion functions for Decimals

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is LGTM. Only perf test remains.

@alexey-milovidov alexey-milovidov merged commit 29b2e26 into ClickHouse:master Dec 12, 2019
@KochetovNicolai KochetovNicolai added the pr-performance Pull request with some performance improvements label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants