fix compilation (std::variant with narrowing) with system libcxx #8147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alexey-milovidov
approved these changes
Dec 12, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Dec 12, 2019
| @@ -245,6 +245,13 @@ set_source_files_properties( | |||
| src/Common/SymbolIndex.cpp | |||
| PROPERTIES COMPILE_FLAGS "-O3 ${WITHOUT_COVERAGE}") | |||
|
|
|||
| # allow construction of std::variant<unsigned ...>(1) for Dwarf | |||
There was a problem hiding this comment.
And that's too heavy, you can define it in source file directly.
This was referenced Dec 12, 2019
Merged
alexey-milovidov
added a commit
that referenced
this pull request
Dec 12, 2019
…rsion Proper fix for #8147
KochetovNicolai
added
the
pr-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qrator Labs s.r.o. contributes this under the terms of the Apache-2.0 license
Changelog category (leave one):