Fixed metrics in BackgroundProcessingPool
#8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes problem introduced in #7670 . |
alexey-milovidov
approved these changes
Dec 12, 2019
KochetovNicolai
added
the
pr-bugfix
|
Conflicts with 19.16 and 19.17 and 19.18 |
|
@KochetovNicolai there is no need to backport it to 19.16 because 19.16 has no pool for background moves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fixed metrics in
BackgroundProcessingPool(they were interfering with metrics of processing pool for moves and could throw exceptionsinvalid arguments passed to getMaxSourcePartsSize: pool_used > pool_sizeduring merges and mutations if there is a storage policy set for a table).