ISSUES-6063 support drop mysql database engine #8202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
changed the title
zhang2014
force-pushed
the
feature/support_drop_mysql_database
branch
from
fed6817
to
713923e
Compare
dbms/src/Databases/DatabaseMySQL.cpp
Outdated
| } | ||
|
|
||
| constexpr static const auto suffix = "_remove.flag"; |
There was a problem hiding this comment.
It will work correctly. But I recomment .remove_flag or .remove.flag just to avoid concatenation of table name with _remove.
Please compare:
items_to_remove_remove.flag
items_to_remove.remove_flag
alexey-milovidov
approved these changes
Dec 14, 2019
KochetovNicolai
added
the
pr-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Support
DROP DATABASE&DETACH TABLE&DROP TABLE&ATTACH TABLEfor MySQL Database Engine.Detailed description (optional):
#6063