Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ICU library from sources. #8219

Merged
merged 2 commits into from
Dec 15, 2019
Merged

Build ICU library from sources. #8219

merged 2 commits into from
Dec 15, 2019

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Build ICU library from sources. This fixes #6460.

@alexey-milovidov alexey-milovidov changed the title Icu Build ICU library from sources. Dec 15, 2019
@alexey-milovidov alexey-milovidov merged commit 753c72a into master Dec 15, 2019
@KochetovNicolai KochetovNicolai added the pr-build Pull request with build/testing/packaging improvement label Dec 16, 2019
@amosbird
Copy link
Collaborator

contrib/icu build somehow introduces libunistring.so.2 dependency with my local toolchain.

@alexey-milovidov
Copy link
Member Author

alexey-milovidov commented Dec 29, 2019

~/work/ClickHouse$ find . -name 'CMakeLists.txt' -or -name '*.cmake' | xargs grep 'unistring'
~/work/ClickHouse$

We don't depend on unistring, only on icu18n, icuuc, icudata.
And we provide our own CMakeLists that are rather clean.

And also we check for dependencies in CI...

@amosbird
Copy link
Collaborator

fortunately that libunistring.so.2 comes from libidn2.so.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build ICU from contrib.
3 participants