Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misconfigured jemalloc #8243

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

amosbird
Copy link
Collaborator

@amosbird amosbird commented Dec 17, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
ClickHouse will build on AArch64 even if MADV_FREE is not available. This fixes #8027

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

I don't know the exact conditions whether is MADV_FREE available (it depends on libc and Linux kernel). Probably it's better to check it explicitly.

But at maximum, replacing MADV_FREE to MADV_DONTNEED will only make jemalloc slightly slower.

@alexey-milovidov alexey-milovidov merged commit 76d876d into ClickHouse:master Dec 17, 2019
@vitlibar vitlibar added the pr-build Pull request with build/testing/packaging improvement label Dec 23, 2019
@quyic
Copy link

quyic commented Oct 12, 2021

[root@zhzj003 ClickHouse]# ninja -j 2
[1/8179] Building C object base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o
FAILED: base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o
/usr/local/bin/gcc -I/alidata/ClickHouse/base/glibc-compatibility/libcxxabi -I/alidata/ClickHouse/base/glibc-compatibility/musl/aarch64 -fdiagnostics-color=always -include /alidata/ClickHouse/base/glibc-compatibility/glibc-compat-2.32.h -pipe -fasynchronous-unwind-tables -falign-functions=32 -Wall -Werror -fomit-frame-pointer -O2 -g -DNDEBUG -O3 -D OS_LINUX -Wno-unused-command-line-argument -Wno-unused-but-set-variable -Wno-builtin-requires-header -std=gnu11 -MD -MT base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o -MF base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o.d -o base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o -c /alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c
/alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c:6:5: error: conflicting types for ‘eventfd’
6 | int eventfd(unsigned int count, int flags)
| ^~~~~~~
In file included from /alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c:1:
/usr/include/sys/eventfd.h:34:12: note: previous declaration of ‘eventfd’ was here
34 | extern int eventfd (int __count, int __flags) __THROW;
| ^~~~~~~
cc1: note: unrecognized command-line option ‘-Wno-builtin-requires-header’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-unused-command-line-argument’ may have been intended to silence earlier diagnostics
[2/8179] Building C object base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/log.c.o
ninja: build stopped: subcommand failed.

I don't know what the problem is. Please help me

@weizuo93
Copy link

[root@zhzj003 ClickHouse]# ninja -j 2 [1/8179] Building C object base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o FAILED: base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o /usr/local/bin/gcc -I/alidata/ClickHouse/base/glibc-compatibility/libcxxabi -I/alidata/ClickHouse/base/glibc-compatibility/musl/aarch64 -fdiagnostics-color=always -include /alidata/ClickHouse/base/glibc-compatibility/glibc-compat-2.32.h -pipe -fasynchronous-unwind-tables -falign-functions=32 -Wall -Werror -fomit-frame-pointer -O2 -g -DNDEBUG -O3 -D OS_LINUX -Wno-unused-command-line-argument -Wno-unused-but-set-variable -Wno-builtin-requires-header -std=gnu11 -MD -MT base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o -MF base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o.d -o base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/eventfd.c.o -c /alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c /alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c:6:5: error: conflicting types for ‘eventfd’ 6 | int eventfd(unsigned int count, int flags) | ^~~~~~~ In file included from /alidata/ClickHouse/base/glibc-compatibility/musl/eventfd.c:1: /usr/include/sys/eventfd.h:34:12: note: previous declaration of ‘eventfd’ was here 34 | extern int eventfd (int __count, int __flags) __THROW; | ^~~~~~~ cc1: note: unrecognized command-line option ‘-Wno-builtin-requires-header’ may have been intended to silence earlier diagnostics cc1: note: unrecognized command-line option ‘-Wno-unused-command-line-argument’ may have been intended to silence earlier diagnostics [2/8179] Building C object base/glibc-compatibility/CMakeFiles/glibc-compatibility.dir/musl/log.c.o ninja: build stopped: subcommand failed.

I don't know what the problem is. Please help me

@quyic
Hi, I encounter the same problem now. Do you resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aarch64 CPU use clang Compiler LLVM ERROR
5 participants