Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affinity for processors pipeline. Fix integration tests. #8362

Merged
merged 6 commits into from Dec 26, 2019

Conversation

KochetovNicolai
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Non-significant (changelog entry is not needed)

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):

@azat
Copy link
Collaborator

azat commented Dec 23, 2019

FWIW with experimental_use_processors (v19.19.1.1929-testing-163-g8711f98c30) I got Pipeline stuck error from time to time, I will try to come back with minimal reproducer (or maybe this is not an issues, and caused by for example network errors or similar)

@KochetovNicolai
Copy link
Member Author

@azat cool! If you have a reproducible example which fails at least sometimes I would be happy to see it.

@@ -11,6 +11,8 @@
#include <Processors/ISource.h>
#include <Common/setThreadName.h>

#include <sched.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this also can be omitted for apple/freebsd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Actually, it's better to add affinity for other os too.

@KochetovNicolai KochetovNicolai changed the title Processors 4.5 Affinity for processors pipeline. Fix integration tests. Dec 26, 2019
@KochetovNicolai KochetovNicolai marked this pull request as ready for review December 26, 2019 09:14
@KochetovNicolai KochetovNicolai merged commit 3ccd33e into master Dec 26, 2019
@vitlibar vitlibar added the pr-improvement Pull request with some product improvements label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants