Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 dependency in v6.6.0 (for TYPO3 v10) #301

Closed
ohader opened this issue Oct 27, 2022 · 5 comments
Closed

PHP 7.4 dependency in v6.6.0 (for TYPO3 v10) #301

ohader opened this issue Oct 27, 2022 · 5 comments

Comments

@ohader
Copy link

ohader commented Oct 27, 2022

protected TSFEUtility $TSFEUtility;

TYPO3 v10 has a minimum requirement of PHP 7.2. The mentioned code location above implicitly requires PHP 7.4 and fails on systems running lower PHP versions.

find . -type f -name '*.php' -exec php72 -l {} \;

PHP Parse error:  syntax error, unexpected 'TSFEUtility' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in ./Classes/UserFunc/PageTitle.php on line 18

Parse error: syntax error, unexpected 'TSFEUtility' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in ./Classes/UserFunc/PageTitle.php on line 18
Errors parsing ./Classes/UserFunc/PageTitle.php

Related commit: 66b9253

ohader added a commit to ohader/cs_seo that referenced this issue Oct 27, 2022
Branch `6x` is targeted for TYPO3 v10 which had a minimum
requirement of PHP 7.2. Using class properties requires at
least PHP 7.4 and fails in any earlier version.

Related: 66b9253
Fixes: clickstorm#301
@ohader
Copy link
Author

ohader commented Oct 27, 2022

Resolved with PR #302

@ohader ohader closed this as completed Oct 27, 2022
@mhirdes
Copy link
Collaborator

mhirdes commented Oct 27, 2022

Thanks for the pull request. PHP 7.2 is not supported since 2 years, but you are right, TYPO3 v10 supports it.

@ohader
Copy link
Author

ohader commented Oct 27, 2022

Thanks for the pull request. PHP 7.2 is not supported since 2 years, but you are right, TYPO3 v10 supports it.

Sure, but there are OS distributions and web hosting providers out there that still actively support PHP 7.2.
Thanks for responding so quickly! 👍

@herzogkienast
Copy link

Hey there,
I'm using TYPO3 V10 and php 7.4 - and need to update cs_seo, but it crashes while updating to 6.6.0. When will there be a version with PHP 7.4 support in TER @mhirdes?
THX in advance.

@mhirdes
Copy link
Collaborator

mhirdes commented Nov 25, 2022

The current version support PHP 7.4. What crashes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants