Fix for showing state below mountpoints #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olofhagsand
reviewed
May 22, 2024
| * So check for the YANG_FLAG_MOUNTPOINT flag on y0 as an alternative. | ||
| * It will only have been set if CLICON_YANG_SCHEMA_MOUNT is enabled | ||
| * and it will be set for exactly those cases where the xml_spec() | ||
| * call is needed. |
There was a problem hiding this comment.
That is a reasonable assumption.
Please remove the "//", see https://github.com/clicon/clixon/blob/master/CONTRIBUTING.md#comments
I see the CLICON_YANG_SCHEMA_MOUNT as getting to be default true eventually as the functionality matures
There was a problem hiding this comment.
I have removed the // line, but have left the /**/ comment left intact, I hope this is OK.
xml_merge1() fails right now when merging trees which have data below mountpoints with an error message like this: XML node %s/%s has no corresponding yang specification (Invalid XML or wrong Yang spec? This is because xml_merge1() does not handle mountpoints. Adjust it accordingly. Note that this was encountered when generating the state of a a yang module that has both state and config below a mountpoint. In that case netconf_trymerge() will be called to merge state and config and will trigger the problem in xml_merge1().
colinhusu
force-pushed
the
mountpoint_state_fix
branch
from
2d1dc95
to
f38a0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating state for a yang module that has both state and config below a mountpoint fails with an error:
This is because netconf_trymerge() will be called to merge state and config, which will in turn trigger a problem in xml_merge1(). Fix that.