Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest misspell broke binary strings #105

Open
karalabe opened this issue Apr 14, 2017 · 3 comments
Open

Latest misspell broke binary strings #105

karalabe opened this issue Apr 14, 2017 · 3 comments

Comments

@karalabe
Copy link

karalabe commented Apr 14, 2017

If I have a large binary blob embedded via go-bindata, the probability is fairly large to have a "misspelling" it it. Would be nice to ignore strings as until now. This worked correctly up until today.

E.g. https://github.com/ethereum/go-ethereum/blob/master/cmd/puppeth/module_dashboard.go#L391

Causing:

cmd/puppeth/module_dashboard.go:391:5782: "ect" is a misspelling of "etc"
cmd/puppeth/module_dashboard.go:391:275585: "ect" is a misspelling of "etc"
cmd/puppeth/module_dashboard.go:391:378784: "ect" is a misspelling of "etc"
@karalabe
Copy link
Author

Most trivial repro:

var variable = "ect"

@karalabe
Copy link
Author

karalabe commented Apr 14, 2017

Further inspection, it works correctly if I explicitly specify --source=go, so it would seem that it fails detecting that my file is Go and doesn't switch to the new ReplaceGo (#104) method.

@karalabe
Copy link
Author

However explicitly specifying go will make it go belly up on non Go files in my repo, so it seems I'm in a deadlock here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant