Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message for "is_empty" condition #12

Closed
wlma opened this issue Oct 31, 2016 · 4 comments
Closed

Wrong error message for "is_empty" condition #12

wlma opened this issue Oct 31, 2016 · 4 comments
Assignees

Comments

@wlma
Copy link

wlma commented Oct 31, 2016

Hi Cliff,
many thanks for your work, saved me from braindeath ;-)

I would suggest to add another condition labeled "empty" or "is empty" to the dependent fields list. Error messages should be adapted accordingly (in German like "keine Werte in Feld xyz"). I my understanding, currently you could build it with "!=" as Condition and "*" as value which results in a wrong error message in the form.

Andreas

@cliffparnitzky
Copy link
Owner

I think this is more a bug when creating the error text.

I will fix the bug and additionally add some help texts to support better understanding of the rule combinations.

@cliffparnitzky cliffparnitzky changed the title Feature-Request: additional condition "is_empty" Wrong error message for "is_empty" condition Nov 8, 2016
@wlma
Copy link
Author

wlma commented Dec 2, 2016

Hi Cliff,

thanks for fixing it, but it looks like there's an issue with the error message if only one depency is needed: in the form-error message is an additional "und" (didn't check in english though, might only in the language file)

formular

@cliffparnitzky cliffparnitzky reopened this Dec 2, 2016
@cliffparnitzky
Copy link
Owner

Hmpf, okay I will check this soon.

@cliffparnitzky
Copy link
Owner

Fixed in e3443ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants