Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups with memberUid instead of memberOf #15

Closed
wants to merge 1 commit into from
Closed

Support groups with memberUid instead of memberOf #15

wants to merge 1 commit into from

Conversation

jplitza
Copy link

@jplitza jplitza commented Nov 4, 2014

There are two ways to represent groups in LDAP: One adds the memberOf attribute to the users of the group, the other adds the memberUid attribute to the group. While combining both is possible, in our setup we only use memberUid, which wasn't supported by Simple-LDAP-Login. This patch adds support.

This isn't the cleanest solution, especially the preg_replace() that kills off any prefixed ou= annoys me, but contrary to what the webinterface says, we had to use ou=People in our base_dn, because that's where our user accounts live (and the plugin tries to authenticate with uid=$username,$base_dn).

@clifgriffin
Copy link
Owner

@jplitza Happy to consider a PR for this, but I think this was probably fixed in 62e5658.

@jplitza
Copy link
Author

jplitza commented Apr 22, 2016

I don't have access to that setup anymore, but I think that commit doesn't fix the problem, because it doesn't check for the attribute "memberUid" anywhere.

@clifgriffin
Copy link
Owner

@jplitza 2169700 should handle it. Allows a custom group UID to be stored in settings.

@phyrog
Copy link

phyrog commented Dec 6, 2016

I'm not sure that this is fixed. As far as I can see, you can now specify the attribute of the user that contains the group ids. What we need instead is to check the groups for an attribute that contains the user ids.

If I'm wrong, please tell :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants