Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APi in the readme #58

Closed
vincenzopalazzo opened this issue Oct 11, 2021 · 3 comments · Fixed by #59
Closed

Update APi in the readme #58

vincenzopalazzo opened this issue Oct 11, 2021 · 3 comments · Fixed by #59
Assignees
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@vincenzopalazzo
Copy link
Member

I wrote the readme a lot of time ago, and I'm a very bad people to make this task.

I discovered that the API about the log level is old, we need to change it from

   @RPCMethod(
            name = "annotation_hello",
            description = "Annotation plugin"
    )
    public void hello(CLightningPlugin plugin, CLightningJsonObject request, CLightningJsonObject response) {
        log(CLightningLevelLog.WARNING, request.toString());
        response.add("type", "random");
    }

To

   @RPCMethod(
            name = "annotation_hello",
            description = "Annotation plugin"
    )
    public void hello(CLightningPlugin plugin, CLightningJsonObject request, CLightningJsonObject response) {
        log(PluginLog.WARNING, request.toString());
        response.add("type", "random");
    }
@vincenzopalazzo vincenzopalazzo added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 11, 2021
@mhechavarria
Copy link
Contributor

Can I work on this, please?

@vincenzopalazzo
Copy link
Member Author

@mhechavarria all yours

@mhechavarria
Copy link
Contributor

Done, please review it: #59

vincenzopalazzo added a commit that referenced this issue Oct 11, 2021
@vincenzopalazzo vincenzopalazzo linked a pull request Oct 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants