Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SavedFields struct into a FieldWriter and FieldMemoryWriter. #29

Closed
ali-ramadhan opened this issue Feb 9, 2019 · 1 comment
Closed

Refactor SavedFields struct into a FieldWriter and FieldMemoryWriter. #29

ali-ramadhan opened this issue Feb 9, 2019 · 1 comment
Assignees
@ali-ramadhan
Labels
abstractions 🎨 Whatever that means cleanup 🧹 Paying off technical debt
Milestone
v0.5

Comments

@ali-ramadhan
Copy link
Member

To fit with the abstract OutputWriter way of dealing with output (whether to memory or disk).
@ali-ramadhan ali-ramadhan added cleanup 🧹 Paying off technical debt feature 🌟 Something new and shiny labels Feb 9, 2019
@ali-ramadhan
Copy link
Member Author

No more saving fields in memory using SavedFields. Now output must be written to disk using a FieldWriter. No plans to make a FieldMemoryWriter as it would be of very limited use.

@ali-ramadhan ali-ramadhan added abstractions 🎨 Whatever that means and removed feature 🌟 Something new and shiny labels Mar 2, 2019
@ali-ramadhan ali-ramadhan added this to the v0.5 milestone Mar 2, 2019
@ali-ramadhan ali-ramadhan self-assigned this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ali-ramadhan ali-ramadhan

Labels
abstractions 🎨 Whatever that means cleanup 🧹 Paying off technical debt
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
1 participant
@ali-ramadhan