Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anisotropic biharmonic diffusivity closure #518

Merged
merged 14 commits into from
Nov 2, 2019

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Oct 30, 2019

This PR implements an anisotropic biharmonic diffusivity closure.

Typically this would be used with zero vertical viscosity / diffusivity, and paired with a constant Laplacian vertical diffusivity. For these, we can use tuples introduced by #517.

I hope to implement an example that uses this feature in a PR coming fairly soon.

Still needs:

  • docs

@glwagner glwagner changed the title Anisotropic biharmonic diffusivity closure [WIP] Anisotropic biharmonic diffusivity closure Oct 30, 2019
@glwagner glwagner changed the title [WIP] Anisotropic biharmonic diffusivity closure Anisotropic biharmonic diffusivity closure Oct 31, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #518 into master will decrease coverage by 1.55%.
The diff coverage is 27.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   66.17%   64.61%   -1.56%     
==========================================
  Files          67       68       +1     
  Lines        1898     1950      +52     
==========================================
+ Hits         1256     1260       +4     
- Misses        642      690      +48
Impacted Files Coverage Δ
src/Oceananigans.jl 75% <ø> (ø) ⬆️
..._implementations/constant_isotropic_diffusivity.jl 100% <ø> (ø) ⬆️
...lementations/anisotropic_biharmonic_diffusivity.jl 0% <0%> (ø)
src/TurbulenceClosures/closure_tuples.jl 50% <100%> (-50%) ⬇️
...mplementations/constant_anisotropic_diffusivity.jl 100% <100%> (ø) ⬆️
src/TurbulenceClosures/TurbulenceClosures.jl 33.33% <26.31%> (-66.67%) ⬇️
src/TurbulenceClosures/closure_operators.jl 66.66% <33.33%> (-13.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8666964...7a765f2. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit 08294f7 into master Nov 2, 2019
@ali-ramadhan ali-ramadhan deleted the glw/mesoscale-closures-biharmonic-diffusivity branch November 2, 2019 11:35
@ali-ramadhan ali-ramadhan restored the glw/mesoscale-closures-biharmonic-diffusivity branch November 3, 2019 12:15
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Anisotropic biharmonic diffusivity closure

Former-commit-id: 08294f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants