test_which: do not mutate os.environ

climbfuji · Dec 8, 2023 · 612edaa · 612edaa
1 parent 2cf6f32
commit 612edaa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/spack/spack/test/util/executable.py b/lib/spack/spack/test/util/executable.py
@@ -89,8 +89,8 @@ def test_which_with_slash_ignores_path(tmpdir, working_env):
         assert exe.path == path
 
 
-def test_which(tmpdir):
-    os.environ["PATH"] = str(tmpdir)
+def test_which(tmpdir, monkeypatch):
+    monkeypatch.setenv("PATH", str(tmpdir))
     assert ex.which("spack-test-exe") is None
 
     with pytest.raises(ex.CommandNotFoundError):