Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDM schema name is hard-coded in cohort generation SQL scripts #4

Closed
ablack3 opened this issue Mar 5, 2021 · 2 comments
Closed

CDM schema name is hard-coded in cohort generation SQL scripts #4

ablack3 opened this issue Mar 5, 2021 · 2 comments
Assignees

Comments

@ablack3
Copy link

ablack3 commented Mar 5, 2021

Description of issue

The name of the cdm schema will be different in each environment but it is hard coded as 'cdm' in the cohort generation SQL scripts. One example is here.

Proposed solution

Add a parameter to the SQL files for the name of the cdm schema and replace all occurrences of the cdm schema name with the parameter.

@justinlimkz
Copy link
Contributor

Hey Adam, thanks for pointing this out - we're on it!

@justinlimkz justinlimkz self-assigned this Mar 5, 2021
@justinlimkz
Copy link
Contributor

I've updated the cohort queries to use the CDM schema specified in config.py, which is what the feature queries were doing. It's passed in through this line in Generators/CohortGenerator.py.

The cohort obtained using gen_EOL_cohort.sql is the same before and after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants