new cohort sql file for v5.3.1. support and a cdm version field in the config file #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
My name is Egill, a postdoc from Erasmus MC in Rotterdam and I was testing your package against some synthetic data. I will eventually also test it on real data.
I needed to make some slight changes to the sql code so it would run on v5.3.1 of the cdm. I think the most common version in use is v5.3.1 so it would be good to support that. The only relevant difference from v5.3.1 to v6 is that the death_dates are not in the person table but in a death table. So I added a new cohort sql file to support that. Then I added a cdm version field in the config.
Then when running the notebooks I just added something like:
I didn't include the notebooks in the pull request since then I would overwrite the figures which are there, and since the data I used was synthetic my figures were not so good to have as an example.
Cheers,
Egill