Minor bugfix in getAccessToken and added 2 new endpoints: addcomment, deletecomment #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, the deleteComment test is invoked by the addComment (chaining). The test posts a comment to a checkin and immediately removes it. Please note that in order to post a comment to a checkin you first have to be a friend of the user the checkin belongs to.
clintandrewhall
added a commit
that referenced
this pull request
Jul 1, 2012
Minor bugfix in getAccessToken and added 2 new endpoints: addcomment, deletecomment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing an "invalid_grant" error during getAccessToken that was not reported as it is embedded in a normal response using the format {error: 'message'}.
I also added 2 endpoints for adding and deleting comments. As the module is currently based on get request I had to refactor a little bit the invokeApi stack.
In order to check that everything works I included some test cases.