fix reward returned in getblockbyheaderheight for "donation" blocks.

thanks to theonenirvana on Slack for finding this

src/currency_core/blockchain_storage.h

@@ -175,6 +175,7 @@ namespace currency
     void print_blockchain(uint64_t start_index, uint64_t end_index);
     void print_blockchain_index();
     void print_blockchain_outs(const std::string& file);
+    bool lookfor_donation(const transaction& tx, uint64_t& donation, uint64_t& royalty);
 
   private:
     typedef std::unordered_map<crypto::hash, size_t> blocks_by_id_index;
@@ -246,7 +247,6 @@ namespace currency
     uint64_t get_adjusted_time();
     bool complete_timestamps_vector(uint64_t start_height, std::vector<uint64_t>& timestamps);
     bool update_next_comulative_size_limit();
-    bool lookfor_donation(const transaction& tx, uint64_t& donation, uint64_t& royalty);
     bool get_block_for_scratchpad_alt(uint64_t connection_height, uint64_t block_index, std::list<blockchain_storage::blocks_ext_by_hash::iterator>& alt_chain, block & b);
     bool process_blockchain_tx_extra(const transaction& tx);
     bool unprocess_blockchain_tx_extra(const transaction& tx);

src/rpc/core_rpc_server.cpp

@@ -521,10 +521,21 @@ namespace currency
   uint64_t core_rpc_server::get_block_reward(const block& blk)
   {
     uint64_t reward = 0;
+    uint64_t royalty = 0;
+    uint64_t donation = 0;
+    uint64_t h = get_block_height(blk);
     BOOST_FOREACH(const tx_out& out, blk.miner_tx.vout)
     {
       reward += out.amount;
     }
+
+  if(h && !(h%CURRENCY_DONATIONS_INTERVAL) /*&& h > 21600*/)
+  {
+    bool r = m_core.get_blockchain_storage().lookfor_donation(blk.miner_tx, donation, royalty);
+    CHECK_AND_ASSERT_MES(r, false, "Failed to lookfor_donation");
+    reward -= donation + royalty;
+  }
+
     return reward;
   }
   //------------------------------------------------------------------------------------------------------------------------------