-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name #76
Comments
I feel like there's some weird string encoding going on here as python2 is famous for its inconsistent handling of strings. Then again, it could be some sort of non-printable unicode character causing the final part to be reversed. Or possibly some regex issue (i.e., needs escaping). I need to look at that code again to see if this is actually the case. EDIT: It would be useful to know what version of the script you're running :) |
It's pretty simple, QoQ (poster, big in here in Holland) is using reversed names for protection (so that automatic tools, can't "destroy" the post). So the reversed name is normal when you download the file ;) I'm running (of course) the latest git version. |
Ah I see now. @clinton-hall what if we try to process the file normally and then try reversing the filename and processing again as a last ditch in case this becomes common practice. |
Yeah, the issue here is these logs are from CouchPotato, not this script? |
No these are from sickbeard, the post processing script ;) Altough I'm not sure if this is sickbeard related or post processing related... |
I believe this is sickbeard related... The names that we pass on are the names of the actual torrents/nzbs etc. It is very difficult for us to intervene and change these.. we do get a return result from sickbeard, so we could try renaming and sending again.... but this would just be a "guess"... the problem is getting an automated way to determine the mode of failure in SB and then change accordingly. Can you provide the actual logs from the postprocess script... I think we can actually do a check for torrent name/nzb name in directory, and reverese torren name/nzb name in directory... if the reverse matches, we pass the reverse... |
This is the whole log file:
Remember, the name I was thinking, if the post processing script is reading the name, why can't it ID the QoQ-sbus(< this is always the same) and if it finds that, reverse it? |
Yep, can do that.. I thought this was an issue with torrent... First time I've ever seen this in nzbs. Thanks for logs... I was about to make major changes in torrent scripts that would have been messy! |
Sorry man! In holland QoQ is well known for the nzb releases, I forgot that foreigners didn't know about QoQ, my bad! And thanks already, happy to help you debug this! |
oeps, sorry I didn't meant to close it. |
Do QoQ only do .mkv releases, or do they do avi etc as well? A lot of questions, but I want to make sure I do this right, not just a quick fix. |
Hi, just wanted to add something to this conversation. NewzNAB solves these issues with, if I remember correctly, the update_parser.php with something like: Sorry, not behind my box at home so it might not be completely accurate but I hope it gives you an idea :) |
I already made a costum script that changed the name in newznab, we're talking here about the filename, this is AFTER you downloaded the NZB. So not sure why you dres this up?
This is a release of them: (they do not use NFO files) |
@ajongsma Yeah that is the old parsing thing, you can delete that, that is just messing with your database. I made a new one. |
Thanks for the details... I should have a fix in dev soon. |
Should now be resolved. Only in dev branch at this time... please let me know if you have any problems with this. |
Not working, this is the log. And yes I'm on the dev branch. |
Ah... The actual nz name that gets passed is structured [=-< Q o Q >-=] but I am just searching for "QoQ" |
Euhm I don't have a lot of knowledge, but aren't you searching for this:
the filename? |
No... I was searching in the nz name first to avoid having to parse all the files names on other downloads |
Just made another change... Test that out. |
For some odd reason I can't seem to get the filename backwards again. how can I test the script manualy witouth download it trought sab everytime? |
To test it, you would need to put the files back into their original location with the original name etc... e.g. check the sabnzbd logs... they might actually show the parameters that were passed. |
Oke so I dubbled checked and the name of the mkv was reversed and changed by the script (nice 👍 ) so it's working for me! (only thing is that I already downloaded it so it isn't moving it, but that's np)
|
Thanks for the confirmation. |
This is weird I downloaded the latest episode of Walking dead again:
|
@clinton-hall does nzbName need to be changed after we change a filename? |
shouldn't need to. |
yeah.. a couple of bugs crept in when we moved functions to their own modules... I have fixed this in the refactor0.7 branch... which we will probably be merging into dev soon. This gave me a good excuse to test and make a few fixes in this refactor branch. This now just searches for "Q o Q" in the filename or the nzbName. I also added a safe name conversion as the folder can't be named [=-< Q o Q >-=] in windows as the "<" and ">" are not permitted in folder or file names!!! |
I just merged these changes into dev. @berkona @jkaberg I think we should be able to continue working in dev branch now and I believe I have resolved all conflicts to allow a merge into Master when we are ready ;) |
Right so to make things clear, git pulling the dev branche will still have the QoQ fix in it this time ? I just did it, now we need to wait for a QoQ release ;) |
Yes, that should be the case. My apologies for the last merge to master. I did some "complete" tests to ensure it worked, but didn't include the QoQ test in that final round :( |
I just got this error:
This is QoQ that is using the name backwards, is there any option to just use the folder name instead ? or perhaps (way better) when the script finds: QoQ-sbusLN string reverse it?
The text was updated successfully, but these errors were encountered: