Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface forwards the fill prop to the DOM #4

Open
rootulp opened this issue Aug 11, 2021 · 0 comments
Open

Surface forwards the fill prop to the DOM #4

rootulp opened this issue Aug 11, 2021 · 0 comments

Comments

@rootulp
Copy link

rootulp commented Aug 11, 2021

Screen Shot 2021-08-10 at 9 15 56 PM

I observe the above error in the console when using the <Surface fill={true}> component. I think we likely don't want to forward fill as a prop to the <div> in

react-neu/src/components/Surface/Surface.tsx

Line 44 in 8f5c31e

const StyledSurface = styled.div<StyledSurfaceProps>`

rootulp added a commit to rootulp/index-ui that referenced this issue Aug 11, 2021
@rootulp
Remove Surface fill prop
b0f1419 
- Remove the `fill` prop from the `<Surface>` component because it
  causes errors of the form
  clintonbembryjr/react-neu#4
- The page looks identical without this prop
@rootulp rootulp mentioned this issue Aug 11, 2021
Merged
controtie pushed a commit to IndexCoop/index-ui that referenced this issue Aug 14, 2021
@rootulp
Remove Surface fill prop (#338)
3994977 
- Remove the `fill` prop from the `<Surface>` component because it
  causes errors of the form
  clintonbembryjr/react-neu#4
- The page looks identical without this prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp