Code review Ottavia and Raul #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for 1989-wall pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
Big congratulations for your project. We enjoyed the review by seeing how you solved some problems, the attention to detail you keep, the general good look of your code, and how well put at the service of a nice project idea it is.
We could go on with the compliments, but saying you did an awesome job it sums it up quite well.
We left some general comments* with ideas about refactoring your code a bit, to make it even better.
Keep it up like this, your are doing great.
(*if you have installed "Comment Anchor" by Starlane Studios , you can scann the files and get the TODO anchors we left.