use less(b, a) for greater(a, b), see also #62

equality test is a problem for some types, which is to say, wrong :)
clipperhouse · Aug 7, 2014 · f5254a8 · f5254a8
1 parent ed75c38
commit f5254a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/typewriters/genwriter/templates.go b/typewriters/genwriter/templates.go
@@ -309,7 +309,7 @@ func (rcv {{.Plural}}) IsSortedBy(less func({{.Pointer}}{{.Name}}, {{.Pointer}}{
 // SortByDesc returns a new, descending-ordered {{.Plural}} slice, determined by a func defining ‘less’. See: http://clipperhouse.github.io/gen/#SortBy
 func (rcv {{.Plural}}) SortByDesc(less func({{.Pointer}}{{.Name}}, {{.Pointer}}{{.Name}}) bool) {{.Plural}} {
 	greater := func(a, b {{.Pointer}}{{.Name}}) bool {
-		return a != b && !less(a, b)
+		return less(b, a)
 	}
 	return rcv.SortBy(greater)
 }
@@ -320,7 +320,7 @@ func (rcv {{.Plural}}) SortByDesc(less func({{.Pointer}}{{.Name}}, {{.Pointer}}{
 // IsSortedDesc reports whether an instance of {{.Plural}} is sorted in descending order, using the pass func to define ‘less’. See: http://clipperhouse.github.io/gen/#SortBy
 func (rcv {{.Plural}}) IsSortedByDesc(less func({{.Pointer}}{{.Name}}, {{.Pointer}}{{.Name}}) bool) bool {
 	greater := func(a, b {{.Pointer}}{{.Name}}) bool {
-		return a != b && !less(a, b)
+		return less(b, a)
 	}
 	return rcv.IsSortedBy(greater)
 }

diff --git a/typewriters/genwriter/test/thing_gen.go b/typewriters/genwriter/test/thing_gen.go
@@ -106,7 +106,7 @@ func (rcv Things) IsSortedBy(less func(Thing, Thing) bool) bool {
 // IsSortedDesc reports whether an instance of Things is sorted in descending order, using the pass func to define ‘less’. See: http://clipperhouse.github.io/gen/#SortBy
 func (rcv Things) IsSortedByDesc(less func(Thing, Thing) bool) bool {
 	greater := func(a, b Thing) bool {
-		return a != b && !less(a, b)
+		return less(b, a)
 	}
 	return rcv.IsSortedBy(greater)
 }
@@ -185,7 +185,7 @@ func (rcv Things) SortBy(less func(Thing, Thing) bool) Things {
 // SortByDesc returns a new, descending-ordered Things slice, determined by a func defining ‘less’. See: http://clipperhouse.github.io/gen/#SortBy
 func (rcv Things) SortByDesc(less func(Thing, Thing) bool) Things {
 	greater := func(a, b Thing) bool {
-		return a != b && !less(a, b)
+		return less(b, a)
 	}
 	return rcv.SortBy(greater)
 }