Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adblockplus.js for more accuracy #2086

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Update adblockplus.js for more accuracy #2086

merged 1 commit into from
Jul 30, 2021

Conversation

mjethani
Copy link
Contributor

This PR updates adblockplus.js for more accuracy.

Changes:

  • Using for...of since that's what Adblock Plus uses too
  • There's a normalization step via Filter.normalize()
  • Lines starting with! are also passed to Filter.fromText()
  • We clear the internal cache so parsing and deserialization are measured more accurately
  • Renamed AdBlockPlus to AdblockPlus

@mjethani mjethani requested a review from remusao as a code owner July 30, 2021 06:55
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Jul 30, 2021
@remusao remusao merged commit 585e3ea into ghostery:master Jul 30, 2021
@mjethani mjethani deleted the more-accurate-adblockplus branch July 30, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao