Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry mechanism while fetching resources #414

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Jan 16, 2020

Fixes #390

Built-in fetch helpers can be used to initialize the adblocker from pre-built presets or raw lists (fetched from multiple sources). In case of failure (e.g. timeout), the whole process of initialization fails. Timeouts are not so uncommon, and retrying to fetch usually succeeds. This PR implements a simple retry-mechanism to make it much more unlikely for initialization of the adblocker to fail.

@remusao remusao merged commit 4ea3f9e into ghostery:master Jan 16, 2020
@remusao remusao added the PR: Polish 💅 Increment patch version when merged label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 Increment patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retry on fetch error?
1 participant