Make sure getId() always returns the same value for a given filter #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
force-pushed
the
fix-id-compute
branch
3 times, most recently
from
4928595
to
066845e
Compare
Previously the value of ID could change after some internal attribute were changed during matching (in particular 'optDomains' and 'optNotDomains' would be sorted to allow more efficient matching which would change the ID).
remusao
force-pushed
the
fix-id-compute
branch
from
066845e
to
8a5e471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the value of ID could change after some internal attribute were changed during matching (in particular 'optDomains' and 'optNotDomains' would be sorted to allow more efficient matching which would change the ID).