Telemetry-22: Properly record in-content searches in the German locale

[past]

@mak77 does this look OK to you? I verified that Yahoo is properly accounted for in both host and results buckets, and Google is counted properly in host only. Getting it counted in results as well would require a more substantial change as the search plugin that ships with the German locale has no locale-specific information. It all happens server-side in Google's servers.

This is also why I had to hardcode the "de" string, it's not the localized build that causes this, but the geolocation of the client.

@luciancor if you are using a localized build, can you verify that this works for you?

[past]

Fixes #22.

[luciancor]

@past I tested using an older german Firefox version (46) and it didn't work but not because of this fix but because of the code here - https://github.com/cliqz-oss/browser-core/blob/test-pilot/specific/firefox/cliqz@cliqz.com/modules/FirefoxTelemetry.jsm#L95 - In Firefox 46 for default yahoo I got the following url https://de.search.yahoo.com/search?p=hello+from+urlbar&ei=UTF-8&fr=moz35

Is there any description regarding the parameters Firefox adds to the search actions?

[past]

@luciancor What do you mean it didn't work? I get the same URL, but the visit is counted in telemetry. Don't you see a testpilottest event in about:telemetry (archived ping data) with "event": "userVisitedEngineResult" and "contentSearch": "yahoo"?

[mak77]

yahoo-de is defined here:
http://searchfox.org/mozilla-central/source/browser/locales/searchplugins/yahoo-de.xml
as pointed out by @luciancor it uses <Param name="fr" value="moz35" /> instead of <Param name="hspart" value="mozilla"/> (en-US), so you need to change "hspart=mozilla" with "fr=moz35", or just add both, it doesn't matter.
Google and Bind just redirect, but they seem to retain the arguments (at least here in Italy).

This is one of the reasons content searches counting is hard, every engine is special as well as every locale.

[mak77]

The other changes look fine to me.

[past]

Thanks for the comments, I updated the check to account for the different parameter in the German locale.