-
Notifications
You must be signed in to change notification settings - Fork 54
/
test_async_transactions.js
2202 lines (1965 loc) · 58 KB
/
test_async_transactions.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim:set ts=2 sw=2 sts=2 et: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
const bmsvc = PlacesUtils.bookmarks;
const obsvc = PlacesUtils.observers;
const tagssvc = PlacesUtils.tagging;
const PT = PlacesTransactions;
const menuGuid = PlacesUtils.bookmarks.menuGuid;
ChromeUtils.defineModuleGetter(
this,
"Preferences",
"resource://gre/modules/Preferences.jsm"
);
// Create and add bookmarks observer.
var observer = {
__proto__: NavBookmarkObserver.prototype,
tagRelatedGuids: new Set(),
reset() {
this.itemsAdded = new Map();
this.itemsRemoved = new Map();
this.itemsChanged = new Map();
this.itemsMoved = new Map();
this.beginUpdateBatch = false;
this.endUpdateBatch = false;
},
handlePlacesEvents(events) {
for (let event of events) {
switch (event.type) {
case "bookmark-added":
// Ignore tag items.
if (event.isTagging) {
this.tagRelatedGuids.add(event.guid);
return;
}
this.itemsAdded.set(event.guid, {
itemId: event.id,
parentGuid: event.parentGuid,
index: event.index,
itemType: event.itemType,
title: event.title,
url: event.url,
});
break;
case "bookmark-removed":
if (this.tagRelatedGuids.has(event.guid)) {
return;
}
this.itemsRemoved.set(event.guid, {
parentGuid: event.parentGuid,
index: event.index,
itemType: event.itemType,
});
}
}
},
onBeginUpdateBatch() {
this.beginUpdateBatch = true;
},
onEndUpdateBatch() {
this.endUpdateBatch = true;
},
onItemChanged(
aItemId,
aProperty,
aIsAnnoProperty,
aNewValue,
aLastModified,
aItemType,
aParentId,
aGuid,
aParentGuid
) {
if (this.tagRelatedGuids.has(aGuid)) {
return;
}
let changesForGuid = this.itemsChanged.get(aGuid);
if (changesForGuid === undefined) {
changesForGuid = new Map();
this.itemsChanged.set(aGuid, changesForGuid);
}
let change = {
isAnnoProperty: aIsAnnoProperty,
newValue: aNewValue,
lastModified: aLastModified,
itemType: aItemType,
};
changesForGuid.set(aProperty, change);
},
onItemVisited: () => {},
onItemMoved(
aItemId,
aOldParent,
aOldIndex,
aNewParent,
aNewIndex,
aItemType,
aGuid,
aOldParentGuid,
aNewParentGuid
) {
this.itemsMoved.set(aGuid, {
oldParentGuid: aOldParentGuid,
oldIndex: aOldIndex,
newParentGuid: aNewParentGuid,
newIndex: aNewIndex,
itemType: aItemType,
});
},
};
observer.reset();
// index at which items should begin
var bmStartIndex = 0;
function run_test() {
bmsvc.addObserver(observer);
observer.handlePlacesEvents = observer.handlePlacesEvents.bind(observer);
obsvc.addListener(
["bookmark-added", "bookmark-removed"],
observer.handlePlacesEvents
);
registerCleanupFunction(function() {
bmsvc.removeObserver(observer);
obsvc.removeListener(
["bookmark-added", "bookmark-removed"],
observer.handlePlacesEvents
);
});
run_next_test();
}
function sanityCheckTransactionHistory() {
Assert.ok(PT.undoPosition <= PT.length);
let check_entry_throws = f => {
try {
f();
do_throw("PT.entry should throw for invalid input");
} catch (ex) {}
};
check_entry_throws(() => PT.entry(-1));
check_entry_throws(() => PT.entry({}));
check_entry_throws(() => PT.entry(PT.length));
if (PT.undoPosition < PT.length) {
Assert.equal(PT.topUndoEntry, PT.entry(PT.undoPosition));
} else {
Assert.equal(null, PT.topUndoEntry);
}
if (PT.undoPosition > 0) {
Assert.equal(PT.topRedoEntry, PT.entry(PT.undoPosition - 1));
} else {
Assert.equal(null, PT.topRedoEntry);
}
}
function getTransactionsHistoryState() {
let history = [];
for (let i = 0; i < PT.length; i++) {
history.push(PT.entry(i));
}
return [history, PT.undoPosition];
}
function ensureUndoState(aExpectedEntries = [], aExpectedUndoPosition = 0) {
// ensureUndoState is called in various places during this test, so it's
// a good places to sanity-check the transaction-history APIs in all
// cases.
sanityCheckTransactionHistory();
let [actualEntries, actualUndoPosition] = getTransactionsHistoryState();
Assert.equal(actualEntries.length, aExpectedEntries.length);
Assert.equal(actualUndoPosition, aExpectedUndoPosition);
function checkEqualEntries(aExpectedEntry, aActualEntry) {
Assert.equal(aExpectedEntry.length, aActualEntry.length);
aExpectedEntry.forEach((t, i) => Assert.equal(t, aActualEntry[i]));
}
aExpectedEntries.forEach((e, i) => checkEqualEntries(e, actualEntries[i]));
}
function ensureItemsAdded(...items) {
let expectedResultsCount = items.length;
for (let item of items) {
if ("children" in item) {
expectedResultsCount += item.children.length;
}
Assert.ok(
observer.itemsAdded.has(item.guid),
`Should have the expected guid ${item.guid}`
);
let info = observer.itemsAdded.get(item.guid);
Assert.equal(
info.parentGuid,
item.parentGuid,
"Should have notified the correct parentGuid"
);
for (let propName of ["title", "index", "itemType"]) {
if (propName in item) {
Assert.equal(info[propName], item[propName]);
}
}
if ("url" in item) {
Assert.ok(
Services.io.newURI(info.url).equals(Services.io.newURI(item.url)),
"Should have the correct url"
);
}
}
Assert.equal(
observer.itemsAdded.size,
expectedResultsCount,
"Should have added the correct number of items"
);
}
function ensureItemsRemoved(...items) {
let expectedResultsCount = items.length;
for (let item of items) {
// We accept both guids and full info object here.
if (typeof item == "string") {
Assert.ok(
observer.itemsRemoved.has(item),
`Should have removed the expected guid ${item}`
);
} else {
if ("children" in item) {
expectedResultsCount += item.children.length;
}
Assert.ok(
observer.itemsRemoved.has(item.guid),
`Should have removed expected guid ${item.guid}`
);
let info = observer.itemsRemoved.get(item.guid);
Assert.equal(
info.parentGuid,
item.parentGuid,
"Should have notified the correct parentGuid"
);
if ("index" in item) {
Assert.equal(info.index, item.index);
}
}
}
Assert.equal(
observer.itemsRemoved.size,
expectedResultsCount,
"Should have removed the correct number of items"
);
}
function ensureItemsChanged(...items) {
for (let item of items) {
Assert.ok(observer.itemsChanged.has(item.guid));
let changes = observer.itemsChanged.get(item.guid);
Assert.ok(changes.has(item.property));
let info = changes.get(item.property);
Assert.ok(!info.isAnnoProperty);
Assert.equal(info.newValue, item.newValue);
if ("url" in item) {
Assert.ok(item.url.equals(info.url));
}
}
}
function ensureItemsMoved(...items) {
Assert.equal(
observer.itemsMoved.size,
items.length,
"Should have received the correct number of moved notifications"
);
for (let item of items) {
Assert.ok(
observer.itemsMoved.has(item.guid),
`Observer should have a move for ${item.guid}`
);
let info = observer.itemsMoved.get(item.guid);
Assert.equal(
info.oldParentGuid,
item.oldParentGuid,
"Should have the correct old parent guid"
);
Assert.equal(
info.oldIndex,
item.oldIndex,
"Should have the correct old index"
);
Assert.equal(
info.newParentGuid,
item.newParentGuid,
"Should have the correct new parent guid"
);
Assert.equal(
info.newIndex,
item.newIndex,
"Should have the correct new index"
);
}
}
function ensureTimestampsUpdated(aGuid, aCheckDateAdded = false) {
Assert.ok(observer.itemsChanged.has(aGuid));
let changes = observer.itemsChanged.get(aGuid);
if (aCheckDateAdded) {
Assert.ok(changes.has("dateAdded"));
}
Assert.ok(changes.has("lastModified"));
}
function ensureTagsForURI(aURI, aTags) {
let tagsSet = tagssvc.getTagsForURI(Services.io.newURI(aURI));
Assert.equal(tagsSet.length, aTags.length);
Assert.ok(aTags.every(t => tagsSet.includes(t)));
}
function createTestFolderInfo(
title = "Test Folder",
parentGuid = menuGuid,
children = undefined
) {
let info = { parentGuid, title };
if (children) {
info.children = children;
}
return info;
}
function removeAllDatesInTree(tree) {
if ("lastModified" in tree) {
delete tree.lastModified;
}
if ("dateAdded" in tree) {
delete tree.dateAdded;
}
if (!tree.children) {
return;
}
for (let child of tree.children) {
removeAllDatesInTree(child);
}
}
// Checks if two bookmark trees (as returned by promiseBookmarksTree) are the
// same.
// false value for aCheckParentAndPosition is ignored if aIsRestoredItem is set.
async function ensureEqualBookmarksTrees(
aOriginal,
aNew,
aIsRestoredItem = true,
aCheckParentAndPosition = false,
aIgnoreAllDates = false
) {
// Note "id" is not-enumerable, and is therefore skipped by Object.keys (both
// ours and the one at deepEqual). This is fine for us because ids are not
// restored by Redo.
if (aIsRestoredItem) {
if (aIgnoreAllDates) {
removeAllDatesInTree(aOriginal);
removeAllDatesInTree(aNew);
} else if (!aOriginal.lastModified) {
// Ignore lastModified for newly created items, for performance reasons.
aNew.lastModified = aOriginal.lastModified;
}
Assert.deepEqual(aOriginal, aNew);
return;
}
for (let property of Object.keys(aOriginal)) {
if (property == "children") {
Assert.equal(aOriginal.children.length, aNew.children.length);
for (let i = 0; i < aOriginal.children.length; i++) {
await ensureEqualBookmarksTrees(
aOriginal.children[i],
aNew.children[i],
false,
true,
aIgnoreAllDates
);
}
} else if (property == "guid") {
// guid shouldn't be copied if the item was not restored.
Assert.notEqual(aOriginal.guid, aNew.guid);
} else if (property == "dateAdded") {
// dateAdded shouldn't be copied if the item was not restored.
Assert.ok(is_time_ordered(aOriginal.dateAdded, aNew.dateAdded));
} else if (property == "lastModified") {
// same same, except for the never-changed case
if (!aOriginal.lastModified) {
Assert.ok(!aNew.lastModified);
} else {
Assert.ok(is_time_ordered(aOriginal.lastModified, aNew.lastModified));
}
} else if (
aCheckParentAndPosition ||
(property != "parentGuid" && property != "index")
) {
Assert.deepEqual(aOriginal[property], aNew[property]);
}
}
}
async function ensureBookmarksTreeRestoredCorrectly(
...aOriginalBookmarksTrees
) {
for (let originalTree of aOriginalBookmarksTrees) {
let restoredTree = await PlacesUtils.promiseBookmarksTree(
originalTree.guid
);
await ensureEqualBookmarksTrees(originalTree, restoredTree);
}
}
async function ensureBookmarksTreeRestoredCorrectlyExceptDates(
...aOriginalBookmarksTrees
) {
for (let originalTree of aOriginalBookmarksTrees) {
let restoredTree = await PlacesUtils.promiseBookmarksTree(
originalTree.guid
);
await ensureEqualBookmarksTrees(
originalTree,
restoredTree,
true,
false,
true
);
}
}
async function ensureNonExistent(...aGuids) {
for (let guid of aGuids) {
Assert.strictEqual(await PlacesUtils.promiseBookmarksTree(guid), null);
}
}
add_task(async function test_recycled_transactions() {
async function ensureTransactThrowsFor(aTransaction) {
let [txns, undoPosition] = getTransactionsHistoryState();
try {
await aTransaction.transact();
do_throw("Shouldn't be able to use the same transaction twice");
} catch (ex) {}
ensureUndoState(txns, undoPosition);
}
let txn_a = PT.NewFolder(createTestFolderInfo());
await txn_a.transact();
ensureUndoState([[txn_a]], 0);
await ensureTransactThrowsFor(txn_a);
await PT.undo();
ensureUndoState([[txn_a]], 1);
ensureTransactThrowsFor(txn_a);
await PT.clearTransactionsHistory();
ensureUndoState();
ensureTransactThrowsFor(txn_a);
let txn_b = PT.NewFolder(createTestFolderInfo());
await PT.batch(async function() {
try {
await txn_a.transact();
do_throw("Shouldn't be able to use the same transaction twice");
} catch (ex) {}
ensureUndoState();
await txn_b.transact();
});
ensureUndoState([[txn_b]], 0);
await PT.undo();
ensureUndoState([[txn_b]], 1);
ensureTransactThrowsFor(txn_a);
ensureTransactThrowsFor(txn_b);
await PT.clearTransactionsHistory();
ensureUndoState();
observer.reset();
});
add_task(async function test_new_folder_with_children() {
let folder_info = createTestFolderInfo(
"Test folder",
PlacesUtils.bookmarks.menuGuid,
[
{
url: "http://test_create_item.com",
title: "Test creating an item",
},
]
);
ensureUndoState();
let txn = PT.NewFolder(folder_info);
folder_info.guid = await txn.transact();
let originalInfo = await PlacesUtils.promiseBookmarksTree(folder_info.guid);
let ensureDo = async function(aRedo = false) {
ensureUndoState([[txn]], 0);
ensureItemsAdded(folder_info);
if (aRedo) {
// Ignore lastModified in the comparison, for performance reasons.
originalInfo.lastModified = null;
await ensureBookmarksTreeRestoredCorrectlyExceptDates(originalInfo);
}
observer.reset();
};
let ensureUndo = () => {
ensureUndoState([[txn]], 1);
ensureItemsRemoved({
guid: folder_info.guid,
parentGuid: folder_info.parentGuid,
index: bmStartIndex,
children: [
{
title: "Test creating an item",
url: "http://test_create_item.com",
},
],
});
observer.reset();
};
await ensureDo();
await PT.undo();
await ensureUndo();
await PT.redo();
await ensureDo(true);
await PT.undo();
ensureUndo();
await PT.clearTransactionsHistory();
ensureUndoState();
});
add_task(async function test_new_bookmark() {
let bm_info = {
parentGuid: PlacesUtils.bookmarks.unfiledGuid,
url: "http://test_create_item.com",
index: bmStartIndex,
title: "Test creating an item",
};
ensureUndoState();
let txn = PT.NewBookmark(bm_info);
bm_info.guid = await txn.transact();
let originalInfo = await PlacesUtils.promiseBookmarksTree(bm_info.guid);
let ensureDo = async function(aRedo = false) {
ensureUndoState([[txn]], 0);
await ensureItemsAdded(bm_info);
if (aRedo) {
await ensureBookmarksTreeRestoredCorrectly(originalInfo);
}
observer.reset();
};
let ensureUndo = () => {
ensureUndoState([[txn]], 1);
ensureItemsRemoved({
guid: bm_info.guid,
parentGuid: bm_info.parentGuid,
index: bmStartIndex,
});
observer.reset();
};
await ensureDo();
await PT.undo();
ensureUndo();
await PT.redo(true);
await ensureDo();
await PT.undo();
ensureUndo();
await PT.clearTransactionsHistory();
ensureUndoState();
});
add_task(async function test_merge_create_folder_and_item() {
let folder_info = createTestFolderInfo();
let bm_info = {
url: "http://test_create_item_to_folder.com",
title: "Test Bookmark",
index: bmStartIndex,
};
let [folderTxnResult, bkmTxnResult] = await PT.batch(async function() {
let folderTxn = PT.NewFolder(folder_info);
folder_info.guid = bm_info.parentGuid = await folderTxn.transact();
let bkmTxn = PT.NewBookmark(bm_info);
bm_info.guid = await bkmTxn.transact();
return [folderTxn, bkmTxn];
});
let ensureDo = async function() {
ensureUndoState([[bkmTxnResult, folderTxnResult]], 0);
await ensureItemsAdded(folder_info, bm_info);
observer.reset();
};
let ensureUndo = () => {
ensureUndoState([[bkmTxnResult, folderTxnResult]], 1);
ensureItemsRemoved(folder_info, bm_info);
observer.reset();
};
await ensureDo();
await PT.undo();
ensureUndo();
await PT.redo();
await ensureDo();
await PT.undo();
ensureUndo();
await PT.clearTransactionsHistory();
ensureUndoState();
});
add_task(async function test_move_items_to_folder() {
let folder_a_info = createTestFolderInfo("Folder A");
let bkm_a_info = { url: "http://test_move_items.com", title: "Bookmark A" };
let bkm_b_info = { url: "http://test_move_items.com", title: "Bookmark B" };
// Test moving items within the same folder.
let [
folder_a_txn_result,
bkm_a_txn_result,
bkm_b_txn_result,
] = await PT.batch(async function() {
let folder_a_txn = PT.NewFolder(folder_a_info);
folder_a_info.guid = bkm_a_info.parentGuid = bkm_b_info.parentGuid = await folder_a_txn.transact();
let bkm_a_txn = PT.NewBookmark(bkm_a_info);
bkm_a_info.guid = await bkm_a_txn.transact();
let bkm_b_txn = PT.NewBookmark(bkm_b_info);
bkm_b_info.guid = await bkm_b_txn.transact();
return [folder_a_txn, bkm_a_txn, bkm_b_txn];
});
ensureUndoState(
[[bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result]],
0
);
let moveTxn = PT.Move({
guid: bkm_a_info.guid,
newParentGuid: folder_a_info.guid,
});
await moveTxn.transact();
let ensureDo = () => {
ensureUndoState(
[[moveTxn], [bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result]],
0
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 0,
newIndex: 1,
});
observer.reset();
};
let ensureUndo = () => {
ensureUndoState(
[[moveTxn], [bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result]],
1
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 1,
newIndex: 0,
});
observer.reset();
};
ensureDo();
await PT.undo();
ensureUndo();
await PT.redo();
ensureDo();
await PT.undo();
ensureUndo();
await PT.clearTransactionsHistory(false, true);
ensureUndoState(
[[bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result]],
0
);
// Test moving items between folders.
let folder_b_info = createTestFolderInfo("Folder B");
let folder_b_txn = PT.NewFolder(folder_b_info);
folder_b_info.guid = await folder_b_txn.transact();
ensureUndoState(
[[folder_b_txn], [bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result]],
0
);
moveTxn = PT.Move({
guid: bkm_a_info.guid,
newParentGuid: folder_b_info.guid,
newIndex: bmsvc.DEFAULT_INDEX,
});
await moveTxn.transact();
ensureDo = () => {
ensureUndoState(
[
[moveTxn],
[folder_b_txn],
[bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result],
],
0
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_b_info.guid,
oldIndex: 0,
newIndex: 0,
});
observer.reset();
};
ensureUndo = () => {
ensureUndoState(
[
[moveTxn],
[folder_b_txn],
[bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result],
],
1
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_b_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 0,
newIndex: 0,
});
observer.reset();
};
ensureDo();
await PT.undo();
ensureUndo();
await PT.redo();
ensureDo();
await PT.undo();
ensureUndo();
// Clean up
await PT.undo(); // folder_b_txn
await PT.undo(); // folder_a_txn + the bookmarks;
Assert.equal(observer.itemsRemoved.size, 4);
ensureUndoState(
[
[moveTxn],
[folder_b_txn],
[bkm_b_txn_result, bkm_a_txn_result, folder_a_txn_result],
],
3
);
await PT.clearTransactionsHistory();
ensureUndoState();
});
add_task(async function test_move_multiple_items_to_folder() {
let folder_a_info = createTestFolderInfo("Folder A");
let bkm_a_info = { url: "http://test_move_items.com", title: "Bookmark A" };
let bkm_b_info = { url: "http://test_move_items.com", title: "Bookmark B" };
let bkm_c_info = { url: "http://test_move_items.com", title: "Bookmark C" };
// Test moving items within the same folder.
let [
folder_a_txn_result,
bkm_a_txn_result,
bkm_b_txn_result,
bkm_c_txn_result,
] = await PT.batch(async function() {
let folder_a_txn = PT.NewFolder(folder_a_info);
folder_a_info.guid = bkm_a_info.parentGuid = bkm_b_info.parentGuid = bkm_c_info.parentGuid = await folder_a_txn.transact();
let bkm_a_txn = PT.NewBookmark(bkm_a_info);
bkm_a_info.guid = await bkm_a_txn.transact();
let bkm_b_txn = PT.NewBookmark(bkm_b_info);
bkm_b_info.guid = await bkm_b_txn.transact();
let bkm_c_txn = PT.NewBookmark(bkm_c_info);
bkm_c_info.guid = await bkm_c_txn.transact();
return [folder_a_txn, bkm_a_txn, bkm_b_txn, bkm_c_txn];
});
ensureUndoState(
[
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
0
);
let moveTxn = PT.Move({
guids: [bkm_a_info.guid, bkm_b_info.guid],
newParentGuid: folder_a_info.guid,
});
await moveTxn.transact();
let ensureDo = () => {
ensureUndoState(
[
[moveTxn],
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
0
);
ensureItemsMoved(
{
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 0,
newIndex: 2,
},
{
guid: bkm_b_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 1,
newIndex: 2,
}
);
observer.reset();
};
let ensureUndo = () => {
ensureUndoState(
[
[moveTxn],
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
1
);
ensureItemsMoved(
{
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 1,
newIndex: 0,
},
{
guid: bkm_b_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 2,
newIndex: 1,
}
);
observer.reset();
};
ensureDo();
await PT.undo();
ensureUndo();
await PT.redo();
ensureDo();
await PT.undo();
ensureUndo();
await PT.clearTransactionsHistory(false, true);
ensureUndoState(
[
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
0
);
// Test moving items between folders.
let folder_b_info = createTestFolderInfo("Folder B");
let folder_b_txn = PT.NewFolder(folder_b_info);
folder_b_info.guid = await folder_b_txn.transact();
ensureUndoState(
[
[folder_b_txn],
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
0
);
moveTxn = PT.Move({
guid: bkm_a_info.guid,
newParentGuid: folder_b_info.guid,
newIndex: bmsvc.DEFAULT_INDEX,
});
await moveTxn.transact();
ensureDo = () => {
ensureUndoState(
[
[moveTxn],
[folder_b_txn],
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
0
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_a_info.guid,
newParentGuid: folder_b_info.guid,
oldIndex: 0,
newIndex: 0,
});
observer.reset();
};
ensureUndo = () => {
ensureUndoState(
[
[moveTxn],
[folder_b_txn],
[
bkm_c_txn_result,
bkm_b_txn_result,
bkm_a_txn_result,
folder_a_txn_result,
],
],
1
);
ensureItemsMoved({
guid: bkm_a_info.guid,
oldParentGuid: folder_b_info.guid,
newParentGuid: folder_a_info.guid,
oldIndex: 0,
newIndex: 0,
});
observer.reset();
};
ensureDo();
await PT.undo();
ensureUndo();
await PT.redo();
ensureDo();
await PT.undo();
ensureUndo();
// Clean up
await PT.undo(); // folder_b_txn
await PT.undo(); // folder_a_txn + the bookmarks;