Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking blocked by sandbox on Linux and Mac #11

Closed
sammacbeth opened this issue Apr 3, 2019 · 3 comments

Comments

@sammacbeth
Copy link
Collaborator

commented Apr 3, 2019

The firefox process sandbox prevents opening of sockets from the content process. We should run the networking on addon parent scope to avoid this. This will need a refactor of the libdweb implementations of TCPSocket and UDPSocket.

@sammacbeth sammacbeth added this to To do in Roadmap Apr 3, 2019

@sammacbeth

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 21, 2019

I put together an implementation of the TCPSocket which runs in the parent scope, and that seems to fix the API. Just need to do the same for UDPSocket then this should be resolved.

libdweb branch with the current progress: https://github.com/sammacbeth/libdweb/tree/tcp-parent

@RangerMauve

This comment has been minimized.

Copy link

commented Aug 21, 2019

Oh HELL yeah! :D

Will that mean support for dat-webext in Cliqz on Linux and Mac? :D

@sammacbeth

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 2, 2019

UDPSocket implementation is now also done. I pushed a new build and this fixes the issue now on both Mac and Linux.

@sammacbeth sammacbeth closed this Sep 2, 2019

@sammacbeth sammacbeth moved this from To do to Done in Roadmap Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.