Fixed link #41
Merged
Fixed link #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konark-cliqz
reviewed
Jun 6, 2017
| @@ -164,7 +164,7 @@ <h1 class="brand-heading">Green Analytics</h1> | |||
|
|
|||
|
|
|||
| <h4>Accessing Dashboard</h4> | |||
| <p> <a href='#'>{{ context.dashboard }}/?token={{ context.site_key }}</a> , | |||
| <p> <a href='#'>{{ context.dashboard }}?token={{ context.site_key }}</a> , | |||
There was a problem hiding this comment.
@philipp-classen : Can you update the protocol to https ? It should be fine now, given that we have https enabled. The best way would be the change the protocol in .env file.
There was a problem hiding this comment.
I don't know if there are side-effects when we set PROTOCOL=https in .env. If I'm not mistaken, it should work, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The landing page shows the link to the dashboard as
http://green-analytics.test.cliqz.com/dashboard/?token=...
which results in 404 Not found.
Changed it, so it shows http://green-analytics.test.cliqz.com/dashboard?token=...
(Did not change it, but https://... would be even better)