Api cleanup + SetManifest for Merger #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ final { | |||
| } | |||
|
|
|||
| // temporary implementation | |||
| fsa::automata_t GetFsa() { | |||
| fsa::automata_t GetFsa() const { | |||
There was a problem hiding this comment.
I suggest have this getter without const qualifier, otherwise its possible to get the pointer from const Dictionary and modify the internal state from outside.
There was a problem hiding this comment.
or we can have a const qualifier, but with return type std::shared_ptr<const Automata> which assures read-only behavior
There was a problem hiding this comment.
hmm, there is no internal state in Automata. So the only state would be the shared pointer itself. I will try it.
There was a problem hiding this comment.
| @@ -69,8 +69,7 @@ final { | |||
| : fsa_(f) { | |||
| } | |||
|
|
|||
| // temporary implementation | |||
| fsa::automata_t GetFsa() const { | |||
| const fsa::automata_t GetFsa() const { | |||
There was a problem hiding this comment.
The first const is not needed, anyway the return value is a temporary object.
|
LGTM! |
hendrikmuhs
added a commit
to hendrikmuhs/keyvi
that referenced
this pull request
Jan 7, 2017
Api cleanup + SetManifest for Merger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup parts from #115