Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 2 cleanup #228

Merged
merged 47 commits into from
Mar 22, 2017
Merged

0 2 cleanup #228

merged 47 commits into from
Mar 22, 2017

Conversation

narekgharibyan
Copy link
Contributor

@hendrikmuhs
Let's merge the 0.2 code now, and do the release on Monday.

hendrikmuhs and others added 30 commits December 4, 2016 21:20
…rebase-300107

# Conflicts:
#	pykeyvi/src/pykeyvi.cpp
# Conflicts:
#	keyvi/src/cpp/dictionary/fsa/generator.h
#	pykeyvi/src/pykeyvi.cpp
#	pykeyvi/src/pykeyvi.pyx
#	pykeyvi/tests/dictionary/dictionary_merger_test.py
The parameter parser avoids code dups but also adds some convenience functionality.
hendrikmuhs and others added 17 commits February 7, 2017 21:51
PR #204 missed a file for IntDictionaryCompiler cython additions, this fixes it as well as adds a test.
# Conflicts:
#	keyvi/SConstruct
#	travis/build_osx_package.sh
keyvi cli params fix for 0.2 branch
# Conflicts:
#	keyvi/src/cpp/dictionary/dictionary_compiler.h
#	keyvi/src/cpp/dictionary/dictionary_merger.h
#	keyvi/tests/cpp/dictionary/dictionary_merger_test.cpp
#	pykeyvi/src/pxds/dictionary_compiler.pxd
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 88.215% when pulling 11d4a0e on 0_2_cleanup into d66009c on master.

@hendrikmuhs hendrikmuhs merged commit fd97ae5 into master Mar 22, 2017
@hendrikmuhs
Copy link
Contributor

@narekgharibyan

Thanks, I will delete the 0_2_cleanup branch after release.

@narekgharibyan narekgharibyan deleted the 0_2_cleanup branch January 19, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants