-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0 2 cleanup #228
Merged
Merged
0 2 cleanup #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C string limit lookup rebase
master to 0_2_cleanup
0 2 cleanup remove deprecated
0 2 cleanup rebase 170107
…rebase-300107 # Conflicts: # pykeyvi/src/pykeyvi.cpp
0 2 cleanup rebase 300107
# Conflicts: # keyvi/src/cpp/dictionary/fsa/generator.h # pykeyvi/src/pykeyvi.cpp # pykeyvi/src/pykeyvi.pyx # pykeyvi/tests/dictionary/dictionary_merger_test.py
The parameter parser avoids code dups but also adds some convenience functionality.
0 2 cleanup #172 rebase2
merge with master
0 2 cleanup memory limit tests
PR #204 missed a file for IntDictionaryCompiler cython additions, this fixes it as well as adds a test.
# Conflicts: # keyvi/SConstruct # travis/build_osx_package.sh
keyvi cli params fix for 0.2 branch
# Conflicts: # keyvi/src/cpp/dictionary/dictionary_compiler.h # keyvi/src/cpp/dictionary/dictionary_merger.h # keyvi/tests/cpp/dictionary/dictionary_merger_test.cpp # pykeyvi/src/pxds/dictionary_compiler.pxd
- fixed merger test cases
latest master changes
Thanks, I will delete the 0_2_cleanup branch after release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hendrikmuhs
Let's merge the 0.2 code now, and do the release on Monday.