-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cancellation during client connection establishment #721
Open
DerGuteMoritz
wants to merge
8
commits into
master
Choose a base branch
from
client-connection-establishment-cancellation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support cancellation during client connection establishment #721
DerGuteMoritz
wants to merge
8
commits into
master
from
client-connection-establishment-cancellation
Commits on Apr 5, 2024
-
Support cancellation during client connection establishment
With #714 we added support for cancelling in-flight HTTP requests by putting the response deferred into an error state. However, this only worked once the underlying TCP connection was established. With this patch, it is now possible to cancel requests even while the connection is still being established (possible since Netty 4.1.108.Final via netty/netty#13849). This also works for `aleph.tcp/client`.
Configuration menu - View commit details
-
Copy full SHA for 9a66ceb - Browse repository at this point
Copy the full SHA 9a66cebView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8e1edd9 - Browse repository at this point
Copy the full SHA 8e1edd9View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad58861 - Browse repository at this point
Copy the full SHA ad58861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 568847c - Browse repository at this point
Copy the full SHA 568847cView commit details
Commits on Apr 19, 2024
-
Introduce utils for making error propagation more self-describing
The new namespace `aleph.util` introduces two new helpers: * `on-error` which is like `d/on-realized` but only for the error case (success case uses `identity`). * `propagate-error` which propagates error states from a source deferred to a destination deferred and optinally accepts a callback which is only run when the propagation has indeed occurred. These are now used in all places where we propagate error states back to upstream deferreds for the purpose of cancellation which hopefully makes it a bit more obvious what's going on.
Configuration menu - View commit details
-
Copy full SHA for d14b846 - Browse repository at this point
Copy the full SHA d14b846View commit details -
Fix test-in-flight-request-cancellation test
See code comment for background
Configuration menu - View commit details
-
Copy full SHA for d2233c6 - Browse repository at this point
Copy the full SHA d2233c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef28e80 - Browse repository at this point
Copy the full SHA ef28e80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e9eef - Browse repository at this point
Copy the full SHA 11e9eefView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.