Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against supported verisons of Clojure #71

Closed
lread opened this issue Oct 3, 2022 · 0 comments · Fixed by #72
Closed

Test against supported verisons of Clojure #71

lread opened this issue Oct 3, 2022 · 0 comments · Fixed by #72

Comments

@lread
Copy link
Collaborator

lread commented Oct 3, 2022

I think clj-yaml's min version of Clojure is 1.8?
Let's test against that and up to 1.11.

Why? I'm not a huge fan of clj-yaml's keyword args convention e.g. (parse-string "42" :keywords false) and know this can behave differently with 1.11. Just want to make sure I don't break us for older versions of Clojure.

lread added a commit to lread/clj-yaml that referenced this issue Oct 3, 2022
Task `bb test` adds `--clj-version` option which can be
1.8, 1.9, 1.10, 1.11 or :all.
Defaults to 1.8

CI adjusted to use `bb test --clj-version :all`.

Includes test reporter that shows test name with clj version.

Closes clj-commons#71
@lread lread closed this as completed in #72 Oct 3, 2022
lread added a commit that referenced this issue Oct 3, 2022
Task `bb test` adds `--clj-version` option which can be
1.8, 1.9, 1.10, 1.11 or :all.
Defaults to 1.8

CI adjusted to use `bb test --clj-version :all`.

Includes test reporter that shows test name with clj version.

Closes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant