Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or silence all existing clj-kondo errors #133

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Fix or silence all existing clj-kondo errors #133

merged 3 commits into from
Apr 28, 2024

Conversation

NoahTheDuke
Copy link
Contributor

@NoahTheDuke NoahTheDuke commented Apr 26, 2024 •
edited
Loading

Add a clj-kondo config and clean up the existing warnings/errors.

Includes a couple small changes, like run! instead of (doall (map ...)).

eerohele
eerohele approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@eerohele eerohele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@NoahTheDuke NoahTheDuke merged commit 06a8b02 into master Apr 28, 2024
@NoahTheDuke NoahTheDuke deleted the nb/clj-kondo branch April 28, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerohele eerohele eerohele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoahTheDuke @eerohele