maint: bump deps #596
maint: bump deps #596
Conversation
Jvm nrepl no longer works with clojure 1.9
Our docs introduce Etaoin with a trip to wikipedia. Our docs are tested with test-doc-blocks. Wikipedia changed a wee bit. Which made our doc tests fail. Adapt.
This step was skipped on test failure. Ironicaly that's the only time I think I really currently need it!
|
Well on the positive side I learned about uploading artifacts on github actions! Something is amiss with our Wikipedia tests. We wait for the search input and I temporarily dumped screenshot. Here it is: It is really not the screen I was expecting... It is not the one I see locally on first hitting Wikipedia: And... there is no search input. |
|
My Mama always told me, "Never test against changing websites, son; it makes for very brittle tests." But I still like the fact that an example in our user guide hits Wikipedia, so I might suffer the occasional breakage. Maybe Wikipedia is rolling out something new as I write this. I'll give it a day and retry. |
|
Ah... well, one thing that is probably happening is that the mobile-friendly view is being presented when hit from CI. Maybe that's most of the issue for the failure. |
Small thing, but sorts jdk8 before jdk11 which makes github actions workflow job listing easier to follow.
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.