Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix push! to push-gateway #38

Merged
merged 3 commits into from
Jan 23, 2020
Merged

fix push! to push-gateway #38

merged 3 commits into from
Jan 23, 2020

Conversation

fastotter
Copy link

With Iapetos 0.1.9 I was getting an IOException on calling push!, despite push-gateway returning status 200. It's caused by a bug in io.prometheus 0.6.0. Updating Iapetos to use io.prometheus 0.8.0 fixes push!.

@MalloZup
Copy link
Member

thx

@MalloZup
Copy link
Member

@danielcompton the travis CI here is running forever since lot of time. Do you know if we can retrigger it? Perhaps a fake commit and rebase

@fastotter cc

@tmatias
Copy link

tmatias commented Jan 14, 2020

would be really nice to have this merged--we are stuck at < 0.10.0 for now :(

let me know if I can help in any way :)

@fastotter
Copy link
Author

Is there something I need to do to finish up this pull request and make the change available to others? I'm new to using git and doing pull requests. I apologize if I'm holding this up.

fastotter

@MalloZup
Copy link
Member

so travis was for some reason stuck on yellow. see my last comment. let see now if it is green we can have it. THX!

@tmatias
Copy link

tmatias commented Jan 22, 2020

awesome! (and sorry to bug again, but would be really cool to have the new version--thank you all, btw!)

@MalloZup MalloZup merged commit 55ae550 into clj-commons:master Jan 23, 2020
@MalloZup
Copy link
Member

@tmatias thx for pinging ! :) enjoy

@WarFox
Copy link

WarFox commented Jun 19, 2020

Can we get a release version 0.1.10 for this change please?

Only able to find [clj-commons/iapetos "0.1.9"], in repositories and that version has this problem when using push-gateway. I had to manually include io.prometheus version 0.8.0 in my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants