Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide correction for "deploy" example #168

Closed
florin-va-oltean opened this issue Apr 10, 2023 · 1 comment · Fixed by #173
Closed

User Guide correction for "deploy" example #168

florin-va-oltean opened this issue Apr 10, 2023 · 1 comment · Fixed by #173

Comments

@florin-va-oltean
Copy link

In User Guide, currently there is this example (at the bottom of the page):

(aether/deploy :coordinates '[lread/mucking-around "1.2.3"]
               :jar-file (io/file "target" "some-library.jar")
               :pom-file (io/file "pom.xml")
               :repository {:url "https://repo.clojars.org"
                            :username (System/getEnv "CLOJARS_USERNAME")
                            :password (System/getEnv "CLOJARS_PASSWORD")})

BUT,
It should be:

(aether/deploy :coordinates '[lread/mucking-around "1.2.3"]
               :jar-file (io/file "target" "some-library.jar")
               :pom-file (io/file "pom.xml")
               :repository {:my-repo {:url "https://repo.clojars.org"
                                                     :username (System/getenv "CLOJARS_USERNAME")
                                                     :password (System/getenv "CLOJARS_PASSWORD")}})

Two differences:

  • repository map should be a map of repo-id -> repo-settings, like {:repo-id {:url "..." :username "..." :password "..."}}
  • System/getEnv should be System/getenv

Ultimately, the first difference probably should be corrected in the code in function deploy-artefacts when building the object DeployRequest .

Note: I tested this with a private repo hosted at https://www.deps.co/

@lread
Copy link
Collaborator

lread commented Apr 11, 2023

@florin-va-oltean thanks so much for raising an issue!
I'll take a peek sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants