We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In User Guide, currently there is this example (at the bottom of the page):
(aether/deploy :coordinates '[lread/mucking-around "1.2.3"] :jar-file (io/file "target" "some-library.jar") :pom-file (io/file "pom.xml") :repository {:url "https://repo.clojars.org" :username (System/getEnv "CLOJARS_USERNAME") :password (System/getEnv "CLOJARS_PASSWORD")})
BUT, It should be:
(aether/deploy :coordinates '[lread/mucking-around "1.2.3"] :jar-file (io/file "target" "some-library.jar") :pom-file (io/file "pom.xml") :repository {:my-repo {:url "https://repo.clojars.org" :username (System/getenv "CLOJARS_USERNAME") :password (System/getenv "CLOJARS_PASSWORD")}})
Two differences:
{:repo-id {:url "..." :username "..." :password "..."}}
System/getEnv
System/getenv
Ultimately, the first difference probably should be corrected in the code in function deploy-artefacts when building the object DeployRequest .
deploy-artefacts
DeployRequest
Note: I tested this with a private repo hosted at https://www.deps.co/
The text was updated successfully, but these errors were encountered:
@florin-va-oltean thanks so much for raising an issue! I'll take a peek sometime soon.
Sorry, something went wrong.
docs: correct user guide deploy example
2af8825
Closes #168
docs: correct user guide deploy example (#173)
d903278
Successfully merging a pull request may close this issue.
In User Guide, currently there is this example (at the bottom of the page):
BUT,
It should be:
Two differences:
{:repo-id {:url "..." :username "..." :password "..."}}
System/getEnv
should beSystem/getenv
Ultimately, the first difference probably should be corrected in the code in function
deploy-artefacts
when building the objectDeployRequest
.Note: I tested this with a private repo hosted at https://www.deps.co/
The text was updated successfully, but these errors were encountered: