Fixes NPE in hashcode with empty keys (Issue 52) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csm
reviewed
Jun 21, 2017
src/potemkin/collections.clj
Outdated
| (unchecked-add acc (bit-xor (.hashCode k) (.hashCode v)))) | ||
| (fn [acc [k v]] | ||
| (unchecked-add acc (bit-xor | ||
| (if k (.hashCode k) 0) |
There was a problem hiding this comment.
Nit, maybe (if (some? k) (.hashCode k) 0), since (not= 0 (.hashCode false))...
There was a problem hiding this comment.
Oh I see what you mean. but its more relevant for a value rather than the key.
There was a problem hiding this comment.
and that's not gonna be a nitpick but we just won't hash false values with my code :)
dpsutton
force-pushed
the
master
branch
2 times, most recently
from
195fadc
to
4bca73a
Compare
|
I'd prefer to use |
|
ah. didn't know about that one. Worked like a charm. Updated @ztellman |
|
Also, can add a test if you would like but it's not particularly complicated. Up to you |
|
No test required, thanks for the report and fix. |
tobias
added a commit
to immutant/immutant
that referenced
this pull request
Jun 23, 2017
…ANT-633] This just ports the fix from clj-commons/potemkin#53 to our vendored potemkin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several alternatives were tried: if you put the whole unchecked-add if
an
(if (and k v) (unchecked-add ...) 0)then you get a hashvalue of0 when there is only one key and a missing value as the key isn't
hashed. If you
(unchecked-add acc (bit-xor (.hashCode (or k 0)) ..then you end up with reflection warnings.