Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem when
walk
function is run on a record type, like this:This happens, 'cause https://github.com/ztellman/potemkin/blob/2473a2bf056f06b03de2e47e4708f28d8a445f38/src/potemkin/walk.clj#L12 the
(coll? form)
check for record returns true, and it in order tries to compose an empty instance of it ((empty form)
).The following is solved in standard
walk
: https://github.com/clojure/clojure/blob/2224dbad5534ff23d3653b07d9dc0a60ba076dd7/src/clj/clojure/walk.clj#L47So, in this PR I've copied this line to make it work: