Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider testing from public API #106

Closed
lread opened this issue Jan 23, 2021 · 1 comment
Closed

Consider testing from public API #106

lread opened this issue Jan 23, 2021 · 1 comment
Labels
Projects

Comments

@lread
Copy link
Collaborator

lread commented Jan 23, 2021

Originally raised by me as lread/rewrite-cljc-playground#25

rewrite-cljc uses import-vars to promote functions from internal namespaces to its public API.

But... tests are typically carried out against internal namespaces instead of the public API.

This means that tests won't catch import-vars errors.

@lread
Copy link
Collaborator Author

lread commented Jan 23, 2021

Another benefit is to folks who look at tests for usage, they will be less likely to use internal APIs.

@lread lread added this to Medium Priority in rewrite-clj Jan 23, 2021
@lread lread added the testing label Jan 23, 2021
@lread lread moved this from Medium Priority to In Progress in rewrite-clj Feb 27, 2021
@lread lread moved this from In Progress to Fixed in v1 branch in rewrite-clj Feb 27, 2021
@lread lread closed this as completed in 5669ddd Mar 10, 2021
rewrite-clj automation moved this from Fixed in v1 branch to Done Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant