Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hickory #62

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Hickory #62

merged 6 commits into from
Jun 19, 2023

Conversation

port19x
Copy link
Contributor

@port19x port19x commented Apr 1, 2023

closes #61

Opening this one early for visibility and convenience.
Todo:

  • add the library to the project.clj and the native-image parameters used
  • amend the my-library/src/simple/main.clj to use the library
  • amend the my-library/README.md with the info you discovered.

@port19x
Copy link
Contributor Author

port19x commented Apr 1, 2023

Note native-image is not a command under a normal archlinux installation of graalvm.
You need to specify the full qualified path.
I modified the project-clj to reflect that.

@port19x
Copy link
Contributor Author

port19x commented Apr 1, 2023

I'd reasonably expect anyone who wants to use hickory to use some requests library too.
Would it be reasonable to extend my demo to cover that?

@port19x
Copy link
Contributor Author

port19x commented Apr 2, 2023

First observation: org.clj-commons/hickory doesn't compile with graalvm, while hickory/hickory does.
This might indicate some regression on 0.7.2+ that I might investigate via a git bisect.

@port19x port19x marked this pull request as ready for review April 3, 2023 09:43
@port19x port19x marked this pull request as draft April 12, 2023 05:50
@port19x
Copy link
Contributor Author

port19x commented Apr 12, 2023

Converting to draft again as I'm now maintainer of hickory and working on ironing out the incompatibility in clj-commons/hickory#77

@port19x port19x marked this pull request as ready for review May 11, 2023 20:11
@port19x
Copy link
Contributor Author

port19x commented May 11, 2023

I consider this done

@port19x
Copy link
Contributor Author

port19x commented Jun 19, 2023

@BrunoBonacci

@BrunoBonacci BrunoBonacci merged commit 57166eb into clj-easy:master Jun 19, 2023
@BrunoBonacci
Copy link
Collaborator

thank you

@port19x port19x deleted the hickory branch June 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hickory and other jsoup dependents are incompatible
2 participants