[#550] ignore reader tag in metadata

clj-kondo · Oct 26, 2019 · 40daf53 · 40daf53
1 parent 3ff1b2f
commit 40daf53
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/src/clj_kondo/impl/analyzer.clj b/src/clj_kondo/impl/analyzer.clj
@@ -1442,5 +1442,5 @@
 ;;;; Scratch
 
 (comment
-  (parse-string "#'foo")
+  (parse-string "#js [1 2 3]")
   )
diff --git a/src/clj_kondo/impl/analyzer/usages.clj b/src/clj_kondo/impl/analyzer/usages.clj
@@ -43,9 +43,9 @@
   ([ctx expr {:keys [:quote? :syntax-quote?] :as opts}]
    (let [ns (:ns ctx)
          ns-name (:name ns)
-         tag (tag expr)
-         quote? (or quote? (= :quote tag))]
-     (if (one-of tag [:unquote :unquote-splicing])
+         t (tag expr)
+         quote? (or quote? (= :quote t))]
+     (if (one-of t [:unquote :unquote-splicing])
        (when-let [f (:analyze-expression** ctx)]
          (f ctx expr))
        (when (or (not quote?)
@@ -54,8 +54,8 @@
                  syntax-quote?)
          (let [syntax-quote?
                (or syntax-quote?
-                   (= :syntax-quote tag))]
-           (case tag
+                   (= :syntax-quote t))]
+           (case t
              :token
              (if-let [symbol-val (symbol-from-token expr)]
                (let [simple-symbol? (empty? (namespace symbol-val))]
@@ -98,7 +98,13 @@
                                                   :config (:config ctx)})))))
                (when (:k expr)
                  (analyze-keyword ctx expr)))
+             :reader-macro
+             (doall (mapcat
+                     #(analyze-usages2 ctx %
+                                       (assoc opts :quote? quote? :syntax-quote? syntax-quote?))
+                     (rest (:children expr))))
              ;; catch-call
              (doall (mapcat
-                     #(analyze-usages2 ctx % (assoc opts :quote? quote? :syntax-quote? syntax-quote?))
+                     #(analyze-usages2 ctx %
+                                       (assoc opts :quote? quote? :syntax-quote? syntax-quote?))
                      (:children expr))))))))))
diff --git a/test/clj_kondo/main_test.clj b/test/clj_kondo/main_test.clj
@@ -1971,6 +1971,8 @@
   (is (empty? (lint! "(import my.ns.Obj) (Obj.)"
                      {:linters {:unresolved-symbol {:level :error}}})))
   (is (empty? (lint! (io/file "project.clj")
+                     {:linters {:unresolved-symbol {:level :error}}})))
+  (is (empty? (lint! "^{:a #js [1 2 3]} [1 2 3]"
                      {:linters {:unresolved-symbol {:level :error}}}))))
 
 (deftest deftest-test