Common error not identified by linter

[FrankApiyo]

version

v2021.03.22

platform

$ java -version
openjdk version "1.8.0_282"
OpenJDK Runtime Environment (build 1.8.0_282-8u282-b08-0ubuntu1~18.04-b08)
OpenJDK 64-Bit Server VM (build 25.282-b08, mixed mode)

problem
clj kondo does not identify a common error

when we have a function that looks as follows:

(defn baz [a b & {:keys [c d] :or {c 10 d 20}}]
         (* a b c d))

sometimes people write it as

(defn baz [a b & {:keys [c d] :or {:c 10 :d 20}}]
         (* a b c d))

please note the colons before c and d
repro

(ns test.issue)
(defn baz [a b & {:keys [c d] :or {:c 10 :d 20}}]
         (* a b c d))

expected behavior
something like....

user:Desktop$ clj-kondo --lint test/issue.clj 
test/issue.clj keyword not expected at line 1
test/issue.clj keyword not expected at line 1
linting took 26ms, errors: 2, warnings: 0

[borkdude]

@FrankApiyo Thanks. Seems like a no-brainer to add some linting around this.

[FrankApiyo]

@borkdude I'm pretty new to this repo, could you point me to the file where this linting might be added?

[borkdude]

@FrankApiyo Yes, here:

clj-kondo/src/clj_kondo/impl/analyzer.clj

Line 257 in 70cef19

:or

[borkdude]

@FrankApiyo Made a minor enhancement here:

0fa71ae